Thread (25 messages) 25 messages, 7 authors, 2014-03-08

[PATCH v2 1/4] pci: OF: Fix the conversion of IO ranges into IO resources.

From: Jason Gunthorpe <hidden>
Date: 2014-02-27 18:19:59
Also in: linux-devicetree, linux-pci, lkml

On Thu, Feb 27, 2014 at 01:06:39PM +0000, Liviu Dudau wrote:
+	if (res->flags & IORESOURCE_IO) {
+		unsigned long port;
+		port = pci_address_to_pio(range->pci_addr);
This looks very suspicious, pci_addr is not unique across all domains,
so there is no way to convert from a pci_addr to the virtual IO
address without knowing the domain number as well.

I would like to see it be:
  port = pci_address_to_pio(range->cpu_addr);

cpu_addr is unique across all domains.

Looking at the microblaze and PPC versions I think the above version
is actually correct (assuming io_base_phys is the CPU address of the
IO window)

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help