Thread (27 messages) 27 messages, 7 authors, 2014-02-23

[PATCH v7 8/8] ARM: sunxi: Add documentation for driver for SD/MMC hosts found on Allwinner sunxi SoCs

From: David Lanzendörfer <hidden>
Date: 2014-02-22 07:33:59
Also in: linux-devicetree, linux-mmc, lkml

Hi
Please use the real compatibles here. It's much easier to search
for. Plus, your driver doesn't support all the SoCs you're mentionning here.
[...]
Please provide the real property name to use. No need for an example
here, you have a full-fledged one in a few lines.
Fixed that.
Ditto. Plus, this is not a mod0 clock.
Yes it is! But maybe the formulation hasn't been clear enough...
You never talked about the clock-names property, and which clocks were
supposed to be provided.
Yes I did? But I expanded the text a little bit further...
quoted
+	interrupts = <0 32 4>;
+	bus-width = <4>;
And you never talked about bus-width either.
I can throw in a line for refering to the mmc slot gpio lib docs.
Isn't the cd-gpios property requested too?
I can refer to the docs there as well if you like... :-)

cheers
david
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140222/909a1b3a/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help