Thread (46 messages) flat view 46 messages, 5 authors, 2014-02-24

[PATCH 03/17] mmc: mmci: Mask IRQs for all variants during runtime suspend

From: Ulf Hansson <hidden>
Date: 2014-02-18 16:36:55
Also in: linux-i2c, linux-mmc, linux-spi, lkml

On 18 February 2014 17:05, Russell King - ARM Linux
[off-list ref] wrote:
On Tue, Feb 04, 2014 at 04:58:44PM +0100, Ulf Hansson wrote:
quoted
In runtime suspended state, we are not expecting IRQs and thus we can
safely mask them, not only for pwrreg_nopower variants but for all.

Obviously we then also need to make sure we restore the IRQ mask while
becoming runtime resumed.
So, what happens when this patch is applied, and a SDIO card is attached
which expects to receive interrupts at any moment?
Currently, no variant implements SDIO irq.

The SDIO irq polling mode from the sdio core will still be functional,
as of today. So, this patch will not break SDIO.
Given that I've run into this during the last week with a SDHCI controller,
I'm not that thrilled with other interfaces doing the same broken thing.
If we add SDIO irq support to mmci in future; parts of that
implementation includes a re-route of DAT1 to a GPIO irq when entering
runtime suspend state. The mmci HW will in runtime suspend state, not
be responsible for handling irqs, which is the same as of today.

Kind regards
Ulf Hansson
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help