Hello Kishon,

-----Original Message-----
From: Kishon Vijay Abraham I [mailto:kishon at ti.com]
Sent: Tuesday, February 11, 2014 5:36 PM
To: Mohit KUMAR DCG; arnd at arndb.de
Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm-
kernel at lists.infradead.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH V6 07/12] phy: st-miphy-40lp: Add SPEAr1310 and
SPEAr1340 PCIe phy support

On Tuesday 11 February 2014 03:00 PM, Mohit Kumar wrote:

quoted

From: Pratyush Anand <redacted>

SPEAr1310 and SPEAr1340 uses miphy40lp phy for PCIe. This driver adds
support for the same.

What's up with SATA support for SPEAr1310? Do you have plans of adding it
soon?

quoted

- yes we will be doing it after this series is finalized.

[...]

quoted

+
+	regmap_update_bits(priv->misc, SPEAR1310_PCIE_MIPHY_CFG_1,
+			SPEAR1310_PCIE_SATA_MIPHY_CFG_PCIE_MASK,
+			SPEAR1310_PCIE_SATA_MIPHY_CFG_PCIE);
+
+	switch (priv->id) {

'id' should be made as optional dt property since it's not used for 1340 no?

- ok
Thanks
Mohit