[PATCH V5 4/8] phy: st-miphy-40lp: Add skeleton driver
From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-02-10 15:54:55
Also in:
linux-devicetree, lkml
On Monday 10 February 2014, Mohit Kumar wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/phy/st-miphy40lp.txt b/Documentation/devicetree/bindings/phy/st-miphy40lp.txt new file mode 100644 index 0000000..d0c7096 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/st-miphy40lp.txt@@ -0,0 +1,12 @@ +Required properties: +- compatible : should be "st,miphy40lp-phy" + Other supported soc specific compatible: + "st,spear1310-miphy" + "st,spear1340-miphy" +- reg : offset and length of the PHY register set. +- misc: phandle for the syscon node to access misc registers +- phy-id: Instance id of the phy. +- #phy-cells : from the generic PHY bindings, must be 1. + - 1st cell: phandle to the phy node. + - 2nd cell: 0 if phy (in 1st cell) is to be used for SATA, 1 for PCIe + and 2 for Super Speed USB.
It's common to start this file with a small header explaining what this hardware is.
quoted hunk ↗ jump to hunk
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index afa2354..2f58993 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig@@ -64,4 +64,10 @@ config BCM_KONA_USB2_PHY help Enable this to support the Broadcom Kona USB 2.0 PHY. +config PHY_ST_MIPHY40LP + tristate "ST MIPHY 40LP driver" + help + Support for ST MIPHY 40LP which can be used for PCIe, SATA and Super Speed USB. + select GENERIC_PHY + endmenu
The 'select' statement should come before 'help', for consistency with the rest of the kernel. Maybe mention that this phy is used inside the spear13xx SoC here rather than a standalone phy.
+ priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+ if (!priv) {
+ dev_err(dev, "can't alloc miphy40lp private date memory\n");
+ return -ENOMEM;
+ }
+
+ priv->plat_ops = (struct miphy40lp_plat_ops *)of_id->data;The cast would incorrectly remove the 'const' attribute of the pointer. Better remove the cast and make priv->plat_ops const.
+static int __init miphy40lp_phy_init(void)
+{
+
+ return platform_driver_probe(&miphy40lp_driver,
+ miphy40lp_probe);
+}
+module_init(miphy40lp_phy_init);There should certainly be a module_exit() function here so you can unload the driver. Arnd