On Tue, Feb 04, 2014 at 09:10:45PM +0100, Thomas Gleixner wrote:

On Mon, 3 Feb 2014, Josh Cartwright wrote:

quoted

+static void qpnpint_irq_ack(struct irq_data *d)
+{
+	struct spmi_pmic_arb_dev *pa = irq_data_get_irq_chip_data(d);
+	u8 irq  = d->hwirq >> 8;
+	u8 apid = d->hwirq;
+	unsigned long flags;
+	u8 data;
+
+	spin_lock_irqsave(&pa->lock, flags);

This wants to be a raw_spinlock - think about RT!

Indeed.  I'll change this in the next revision.

Looks sane otherwise.

Great, thanks for taking a look!

  Josh

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation