Thread (1 message) 1 message, 1 author, 2014-01-20
DORMANTno replies

[PATCH] ARM: mvebu: fix compilation warning on Armada 370 (i.e. non-SMP)

From: Arnaud Ebalard <hidden>
Date: 2014-01-20 21:42:18

Hi Arnd,

Arnd Bergmann [off-list ref] writes:
On Monday 20 January 2014 21:14:13 Arnaud Ebalard wrote:
quoted
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index 433cc8568dec..499c5070f841 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -59,7 +59,9 @@
 #define PCI_MSI_DOORBELL_END                    (32)
 #define PCI_MSI_DOORBELL_MASK                   0xFFFF0000
 
+#ifdef CONFIG_SMP
 static DEFINE_RAW_SPINLOCK(irq_controller_lock);
+#endif
 
 static void __iomem *per_cpu_
How about moving it inside of the existing #ifdef?

That also brings it closer to the one place it's used.
I also hesitated but decided to let the declaration of this global
at the beginning of the file. I will send a v2 with the declaration
moved inside the existing #ifdef.

Cheers,

a+
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help