[PATCH 13/15] fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

From
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date
2014-01-19 21:01:29
Also in
linux-fbdev, linux-sh
Reply to
Tomi Valkeinen, 2014-01-17
Hi Tomi,

On Friday 17 January 2014 11:00:58 Tomi Valkeinen wrote:
Hi,

On 2014-01-08 10:30, Tomi Valkeinen wrote:
quoted
On 2014-01-07 17:15, Laurent Pinchart wrote:
quoted
On Wednesday 11 December 2013 13:51:18 Laurent Pinchart wrote:
quoted
Hi Jean-Christophe and Tomi,

Could you please pick this patch up for v3.14 ?
Ping ?
Queued for 3.14.
I'll drop this patch, as it causes compile break (from kbuild test robot):

All error/warnings:

   drivers/built-in.o: In function `sh_mobile_lcdc_pan':
quoted
quoted
sh_mobile_lcdcfb.c:(.text+0x77373): undefined reference to
`sh_mobile_meram_cache_update'
   drivers/built-in.o: In function `sh_mobile_lcdc_start':
quoted
quoted
sh_mobile_lcdcfb.c:(.text+0x79320): undefined reference to
`sh_mobile_meram_cache_free'
quoted
quoted
sh_mobile_lcdcfb.c:(.text+0x79394): undefined reference to
`sh_mobile_meram_cache_alloc'
quoted
quoted
sh_mobile_lcdcfb.c:(.text+0x793d4): undefined reference to
`sh_mobile_meram_cache_update'
   drivers/built-in.o: In function `sh_mobile_lcdc_stop':
quoted
quoted
sh_mobile_lcdcfb.c:(.text+0x79616): undefined reference to
`sh_mobile_meram_cache_free'
The lcdc driver can be compiled without meram support. This is handled by 
conditional compilation in include/video/sh_mobile_meram.h that defines the 
meram functions as stubs when meram support isn't selected.

The problem comes from the combination of FB_SH_MOBILE_MERAM=m and 
FB_SH_MOBILE_LCDC=y. The former makes the meram function non-stubs, while the 
later makes the LCDC driver fail to link, as meram support is then compiled as 
a module.

How do you usually handle this ?

-- 
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140119/329d9343/attachment.sig>
Thread (63 messages) 63 messages, 14 authors, last reply 2014-03-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help