Thread (1 message) 1 message, 1 author, 2014-01-17
DORMANTno replies

[PATCH] mmc: dw_mmc: fix dw_mci_get_cd

From: Chris Ball <hidden>
Date: 2014-01-17 14:25:30
Also in: linux-mmc

Hi,

On Fri, Jan 17 2014, Seungwon Jeon wrote:
On Fri, January 17, 2014, Kevin Hilman wrote:
quoted
Zhangfei Gao [off-list ref] writes:
quoted
Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b
CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc)
can not be checked by IS_ERR_VALUE.
Add spin_lock_bh(&host->lock) for atomic accessing DW_MMC_CARD_PRESENT,
otherwise sd detect may occasionally fail.

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Reported-by: Kevin Hilman <redacted>
Reviewed-by: Sachin Kamat <redacted>
Tested-by: Sachin Kamat <redacted>
I didn't look at the patch in detail, but can at least confirm that
Arndale boots again in -next with this patch applied.

Tested-by: Kevin Hilman <redacted>
Acked-by: Seungwon Jeon <redacted>
Thanks, pushed to mmc-next for 3.14.

- Chris.
-- 
Chris Ball   [off-list ref]   <http://printf.net/>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help