Thread (4 messages) flat view 4 messages, 3 authors, 2014-01-20
STALE4616d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] dma: imx-sdma: remove firmare not found warning

From: Shawn Guo <hidden>
Date: 2014-01-17 06:10:24

On Thu, Jan 16, 2014 at 04:46:26PM +0100, Sascha Hauer wrote:
When a firmware cannot be found for the SDMA engine then we can
continue with the inernal ROM firmware.

The meaning of this message is frequently asked for and the usual
answer is that this message is of no relevance, so just make it
dev_dbg() and do not alienate the users anymore.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Vinod Koul <redacted>
Acked-by: Shawn Guo <redacted>
quoted hunk ↗ jump to hunk
---
 drivers/dma/imx-sdma.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index c75679d..fe57a42 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1259,7 +1259,10 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
 	unsigned short *ram_code;
 
 	if (!fw) {
-		dev_err(sdma->dev, "firmware not found\n");
+		dev_dbg(sdma->dev, "firmware not found\n");
+		/*
+		 * In this case we just use the ROM firmware.
+		 */
 		return;
 	}
 
-- 
1.8.5.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help