Thread (15 messages) flat view 15 messages, 5 authors, 2014-01-22
STALE4587d

Revision v6 of 2 in this series.

Revisions (2)
  1. v6 [diff vs current]
  2. v6 current

[PATCH v6 0/3] AArch64: KGDB support

From: catalin.marinas@arm.com (Catalin Marinas)
Date: 2014-01-16 13:45:50

On Thu, Dec 19, 2013 at 11:50:48AM +0000, vijay.kilari at gmail.com wrote:
Vijaya Kumar K (3):
  AArch64: KGDB: Add Basic KGDB support
  AArch64: KGDB: Add step debugging support
  KGDB: make kgdb_breakpoint() as noinline
I gave them a try and now I have some doubts about your testing
methodology:

1. There is no HAVE_ARCH_KGDB anywhere in these patches, so
the code here isn't compiled.

2. There are several compiler warnings that need to be addressed.

3. I enabled CONFIG_KGDB_TESTS and CONFIG_KGDB_TESTS_ON_BOOT and that's
what really scared me.

Please address these before we can consider the patches for merging.

-- 
Catalin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help