Thread (4 messages) 4 messages, 3 authors, 2014-01-13
STALE4527d REVIEWED: 1 (0M)

[PATCH V2 1/2] mmc: sdhci-esdhc-imx: fix access hardirq-unsafe lock in atomic context

From: Dong Aisheng <hidden>
Date: 2014-01-13 10:52:54
Also in: linux-mmc

Hi Chris,

On Tue, Dec 31, 2013 at 1:24 PM, Shawn Guo [off-list ref] wrote:
On Thu, Dec 26, 2013 at 03:23:53PM +0800, Dong Aisheng wrote:
quoted
Sometimes we may meet the following lockdep issue.
The root cause is .set_clock callback is executed with spin_lock_irqsave
in sdhci_do_set_ios. However, the IMX set_clock callback will try to access
clk_get_rate which is using a mutex lock.

The fix avoids access mutex in .set_clock callback by initializing the
pltfm_host->clock at probe time and use it later instead of calling
clk_get_rate again in atomic context.
<snip>
quoted
Cc: Chris Ball <redacted>
Cc: Fabio Estevam <redacted>
Cc: Shawn Guo <redacted>
For both,

Acked-by: Shawn Guo <redacted>
quoted
Fixes: 0ddf03c mmc: esdhc-imx: parse max-frequency from devicetree
Signed-off-by: Dong Aisheng <redacted>
Can we make patch 1 go into 3.13 final since the issue exists
since 3.13 rc1.

Patch 2 in that series is the fix for sdhci-esdhc-imx runtime pm which is
newly added in chris/mmc-next and seems target for 3.14.

BTW, pls add:
Tested-by: Philippe De Muyter <redacted>

See:
https://lkml.org/lkml/2014/1/13/77

Regards
Dong Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help