Re: [PATCH 1/2] spi: clps711x: Driver refactor

On Wednesday 01 January 2014, Mark Brown wrote:

quoted

quoted

As an alternative, I can create patch to remove current driver,
then re-adding new one.  Will be more convenient to watch. Is it better? 

No, that's really not good.  It's very rare that we just completely
rewrite a driver especially not one that's been around for a while -
there needs to be a really good reason for it.  This is a key part of
how the development process works, incremental improvements and code
review.  Doing this both helps improve quality control on changes and
allows collaboration.

I definitely agree with what you say, but please note that Alexander is
the only person who ever sends clps711x patches, so there is not much
hope of collaboration. I also suspect he's the only one who would
suffer from accidental breakage, especially since the existing driver
is not used anywhere upstream (no instance of platform data, and no
DT support).

Thanks for protection Arnd :) 
Indeed, all as you say, of course it does not mean that I got VIP status and
can make any changes to the kernel tree,
make me comments - I'm learning this.

---