On Wed, Jan 29, 2014 at 10:11 AM, Suravee Suthikulanit
[off-list ref] wrote:

On 1/17/2014 5:08 AM, Andreas Herrmann wrote:

quoted

arm-smmu driver uses of_parse_phandle_with_args when parsing DT
information to determine stream IDs for a master device.
Thus the number of stream IDs per master device is bound by
MAX_PHANDLE_ARGS.

To support Calxeda ECX-2000 hardware arm-smmu driver requires a
slightly higher value for MAX_PHANDLE_ARGS as this hardware has 10
stream IDs for one master device.

Increasing it to 16 seems a reasonable choice.

Cc: Grant Likely <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree at vger.kernel.org
Cc: Andreas Herrmann <redacted>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Andreas Herrmann <redacted>
---
  include/linux/of.h |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/of.h b/include/linux/of.h
index 276c546..24e1b28 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h

@@ -67,7 +67,7 @@ struct device_node {
  #endif
  };

-#define MAX_PHANDLE_ARGS 8
+#define MAX_PHANDLE_ARGS 16

Since the MMU-500 specify "Number of SMRs" upto 128 registers, shouldn't
this be changed to be able to support 128 StreamIDs as well?  Although I am
not sure if this would be too big to have on the stack per Rob's comment in
the previous patch set.

Do you actually need 128 now? If not, then we can deal with that when
we get there. There are lots of things in spec's that are not actually
implemented or supported.

Rob