[PATCH v3 1/2] i2c: qup: Add device tree bindings information
From: Bjorn Andersson <hidden>
Date: 2014-01-23 20:22:12
Also in:
linux-arm-msm, linux-devicetree, linux-i2c
On Thu, Jan 23, 2014 at 11:11 AM, Matthew Locke [off-list ref] wrote:
Rob, On Jan 20, 2014, at 8:10 AM, Rob Herring wrote:quoted
On Fri, Jan 17, 2014 at 5:03 PM, Bjorn Andersson
[...]
quoted
quoted
+Required properties: + - compatible: Should be "qcom,i2c-qup".Seems a bit generic. All versions of the IP are exactly the same? "qcom,<chip>-i2c-qup" would be better.The QUP IP block is the same across chips. Its possible there could be different versions of the IP block but its pretty stable now.
I have not been able to find any differences in this block between 8960 and 8074 and I have successfully tested the driver on both platforms. So the reason for making it more specific would be to handle any future crazyness. Not sure what to do about this though, I have never heard about the version numbers Stephen gave us and I can't find them in the documentation available to us, so I wouldn't know which of the two to select... Regards, Bjorn