[PATCH v2 14/15] watchdog: orion: Allow to build on any Orion platform
From: Ezequiel Garcia <hidden>
Date: 2014-01-21 10:04:35
Also in:
linux-devicetree, linux-watchdog
Hi Andrew, Sebastian: On Tue, Jan 21, 2014 at 10:45:01AM +0100, Andrew Lunn wrote:
On Tue, Jan 21, 2014 at 10:41:17AM +0100, Sebastian Hesselbarth wrote:quoted
On 01/21/14 10:12, Ezequiel Garcia wrote:quoted
After getting rid of all the mach-specific code, it's now possible to allow builds in any Orion platform. Signed-off-by: Ezequiel Garcia <redacted> --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 5be6e91..1689f72 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig@@ -282,7 +282,7 @@ config DAVINCI_WATCHDOG config ORION_WATCHDOG tristate "Orion watchdog" - depends on ARCH_ORION5X || ARCH_KIRKWOOD || ARCH_DOVE + depends on PLAT_ORION
[..]
quoted
while above is true now, I tend to rather have ARCH_MVEBU added here. We really want to get rid of both !ARCH_MVEBU and PLAT_ORION and this unnecessarily will make it more complicated. I haven't checked why ARCH_MVEBU at all added PLAT_ORION as dependency, but IIRC it was just because of a missing mbus driver? If it is just this, we should also remove PLAT_ORION from ARCH_MVEBU to have a clean cut between new common arch and existing sub-archs.
Hm... not sure why we depend on PLAT_ORION. I'll take a look.
I took a look at this when moving DT kirkwood into mach-mvebu. There is nothing in plat-orion which ARCH_MVEBU needs. So i agree with Sebastian, it should be PLAT_ORION || ARCH_MVEBU.
OK, will do. Thanks! -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com