[PATCH v3 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver
From: broonie@kernel.org (Mark Brown)
Date: 2014-01-31 12:48:37
Also in:
linux-devicetree, linux-spi, lkml
On Fri, Jan 31, 2014 at 11:55:50AM +0100, Maxime Ripard wrote:
+ master = devm_spi_alloc_master(&pdev->dev, sizeof(struct sun6i_spi));
+ if (!master) {
+ dev_err(&pdev->dev, "Unable to allocate SPI Master\n");
+ return -ENOMEM;
+ }This now depends on your other series which as I said doesn't look like the best approach.
+ pm_runtime_enable(&pdev->dev);
+ if (!pm_runtime_enabled(&pdev->dev)) {
+ ret = sun6i_spi_runtime_resume(&pdev->dev);
+ if (ret) {
+ dev_err(&pdev->dev, "Couldn't resume the device\n");
+ return ret;
+ }
+ }No, as discussed don't do this - notice how other drivers aren't written this way either. Like I said leave the device powered on startup and then let it be idled by runtime PM. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140131/768cbcd7/attachment.sig>