[RFC PATCH V2 3/4] dt-bindings: pci: xgene pcie device tree bindings

On Wed, Jan 15, 2014 at 1:57 AM, Arnd Bergmann [off-list ref] wrote:

On Wednesday 15 January 2014, Tanmay Inamdar wrote:

quoted

This patch adds the bindings for X-Gene PCIe driver. The driver resides
under 'drivers/pci/host/pci-xgene.c' file.

Signed-off-by: Tanmay Inamdar <redacted>
---
 .../devicetree/bindings/pci/xgene-pcie.txt         |   45 ++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/xgene-pcie.txt

diff --git a/Documentation/devicetree/bindings/pci/xgene-pcie.txt b/Documentation/devicetree/bindings/pci/xgene-pcie.txt
new file mode 100644
index 0000000..19b9c28
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/xgene-pcie.txt

@@ -0,0 +1,45 @@
+* AppliedMicro X-Gene PCIe interface
+
+Required properties:
+- status: Either "ok" or "disabled".

"status" isn't normally a required property. The default interpretation is
that a node without a status property is active.

ok. I will move 'status' under optional properties.

quoted

+- device_type: set to "pci"
+- compatible: should contain "xgene,pcie" to identify the core.
+- reg: base addresses and lengths of the pcie controller configuration
+     space register.

Doesn't match the code or example: You only list one area here, but
you actually need to register sets.

ok. I will update

Looks good otherwise now.

        Arnd