Thread (3 messages) flat view 3 messages, 3 authors, 2014-01-14

[PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource

From: marex@denx.de (Marek Vasut)
Date: 2014-01-14 13:17:08
Also in: linux-pci, lkml

On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote:
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <redacted>
True that,

Acked-by: Marek Vasut <marex@denx.de>
quoted hunk ↗ jump to hunk
---

Should go via subsystem tree

 drivers/pci/host/pci-imx6.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
index bd70af8..5002e23 100644
--- a/drivers/pci/host/pci-imx6.c
+++ b/drivers/pci/host/pci-imx6.c
@@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct
platform_device *pdev) "imprecise external abort");

 	dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!dbi_base) {
-		dev_err(&pdev->dev, "dbi_base memory resource not found\n");
-		return -ENODEV;
-	}
-
 	pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
 	if (IS_ERR(pp->dbi_base)) {
 		ret = PTR_ERR(pp->dbi_base);
Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help