On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote:

On 01/08/2014 06:39 AM, Thierry Reding wrote:

quoted

On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote:

quoted

On 12/24/2013 06:32 AM, Peter De Schrijver wrote:

[...]

quoted

quoted

diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi

quoted

+	efuse at 7000F800 {

"fuse" might be a better node name; "efuse" is presumably the name of
the instance, not the type of object.

There's another occurrence I noticed recently where we haven't followed
that rule. The PMIC node on Venice2 for instance is called as3722.
Perhaps that should also be renamed.

Yes, we should fix that. Care to send a patch?

Ugh... I've just been going through some of the other DTS files and see
that quite a lot of other places aren't following this rule either. The
Beaver DTS has things like:

		rt5640: rt5640 at 1c {
			...
		};

which I guess "should have been"

		rt5640: codec at 1c { /* or even audio-codec at 1c */
			...
		};

and

		pmic: tps65911 at 2d {
			...
		};

which would be another candidate for pmic at 2d.

Perhaps it isn't worth fixing them all up after all?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140108/a8bf636c/attachment.sig>