[PATCH] of/platform: Fix no irq domain found errors when populating interrupts
From: paul@pwsan.com (Paul Walmsley)
Date: 2014-01-06 23:41:45
Also in:
linux-devicetree, linux-omap, lkml
Hi Tony, Rob, On Tue, 31 Dec 2013, Rob Herring wrote:
On Mon, Dec 30, 2013 at 4:10 PM, Paul Walmsley [off-list ref] wrote:quoted
Hi Grant, Rob, On Tue, 10 Dec 2013, Paul Walmsley wrote:quoted
On Sun, 24 Nov 2013, Grant Likely wrote:quoted
On Fri, 22 Nov 2013 17:50:35 -0800, Tony Lindgren [off-list ref] wrote:quoted
* Tony Lindgren [off-list ref] [131122 17:16]:quoted
* Tony Lindgren [off-list ref] [131122 17:09]:quoted
* Russell King - ARM Linux [off-list ref] [131122 16:56]:quoted
On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote:quoted
+ /* See of_device_resource_notify for populating interrupts */ + for (i = 0; i < num_irq; i++, res++) { + res->flags = IORESOURCE_IRQ; + res->start = -EPROBE_DEFER; + res->end = -EPROBE_DEFER;NAK. Definitely a bad idea to start introducing magic values other into resources. Please don't do this.Do you have any better ideas on how to sort out this issue then?I guess we could allocate all the resources lazily here, I'll take a look at that.Here's a version that allocates the resources lazily with the notifier. Seems to boot, need to play with it a bit more though to make sure we're not overwriting resources for any legacy devices.Blurg. Using a notifier really feels like we don't have a good handle on a reasonable solution yet. Basically it means we're hooking into the driver core without /looking/ like we're hooking into the driver core. I don't think this is any better, but I don't have a better suggestion at the moment. :-(Unfortunately this patch, or something that accomplishes the same results, is somewhat high-priority for us on OMAP. OMAP37xx got prematurely converted to DT booting, and now dynamic power management is broken: http://marc.info/?l=linux-arm-kernel&m=138658294830408&w=2 Tony writes that this patch is one of the two patches needed to get things working again: http://marc.info/?l=linux-arm-kernel&m=138660942506846&w=2 Is it possible to get this patch, or something similar, merged for v3.13-rc? Once something like PM is broken, it's pretty easy for other broken patches to make it into the tree, since it becomes very difficult to test without turning into a maintainer denial-of-service attack.Ping. Could you please provide some guidance here about what you'd need to get this solved for v3.13-rc?I agree with doing the platform_get_irq modification and feel free to add my ack. I'm going to be offline for the next week.
Thanks Rob! Tony, would you consider sending this patch upstream for v3.13-rc along with your 37xxevm fix patches? - Paul