[PATCH 23/25] thermal: exynos: fix error return code
From: rui.zhang@intel.com (Zhang Rui)
Date: 2014-01-02 01:55:45
Also in:
kernel-janitors, linux-pm, linux-samsung-soc, lkml
On Sun, 2013-12-29 at 23:47 +0100, Julia Lawall wrote:
From: Julia Lawall <redacted> Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if at p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret at p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <redacted>
applied. thanks, rui
quoted hunk ↗ jump to hunk
--- Not tested. drivers/thermal/samsung/exynos_tmu.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 32f38b9..0d96a51 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c@@ -205,6 +205,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) skip_calib_data: if (pdata->max_trigger_level > MAX_THRESHOLD_LEVS) { dev_err(&pdev->dev, "Invalid max trigger level\n"); + ret = -EINVAL; goto out; }