Thread (8 messages) flat view 8 messages, 6 authors, 2013-12-20
STALE4645d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] pci: designware: fix missing msi irqs

From: Mohit KUMAR DCG <hidden>
Date: 2013-12-16 06:48:46
Also in: linux-pci

-----Original Message-----
From: Jingoo Han [mailto:jg1.han at samsung.com]
Sent: Monday, December 16, 2013 6:24 AM
To: 'Harro Haan'; Mohit KUMAR DCG
Cc: 'Bjorn Helgaas'; 'Marek Vasut'; 'Richard Zhu'; 'Shawn Guo'; Pratyush
ANAND; 'Tim Harvey'; 'Juergen Beisert'; 'Arnd Bergmann'; 'Siva Reddy
Kallam'; 'Srikanth T Shivanand'; 'Sean Cross'; linux-pci at vger.kernel.org; linux-
arm-kernel at lists.infradead.org; 'Jingoo Han'
Subject: Re: [PATCH] pci: designware: fix missing msi irqs

On Friday, December 13, 2013 3:29 AM, Harro Haan wrote:
quoted
The interrupts were cleared after the irq handler was called.
This means that new interrupts that occur after the handler handled
the previous irq but before the interrupt is cleared will be missed.

Signed-off-by: Harro Haan <redacted>
Cc: Mohit Kumar <redacted>
Cc: Jingoo Han <redacted>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Richard Zhu <redacted>
Cc: Shawn Guo <redacted>
Cc: Pratyush Anand <redacted>
Cc: Tim Harvey <tharvey@gateworks.com>
Cc: Juergen Beisert <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Siva Reddy Kallam <redacted>
Cc: Srikanth T Shivanand <redacted>
Cc: Sean Cross <redacted>
Cc: linux-pci at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Acked-by: Jingoo Han <redacted>

I was not able to reproduce the problem, however it looks good. Also, there
is no side effect on Exynos platform.

Mohit,
If you have some comments, please let us know.
- Quickly tested on SPEAr1310, working fine without any side effect. So is,
Acked-by: Mohit Kumar <redacted>
..
quoted
---
 drivers/pci/host/pcie-designware.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help