[linux-sunxi] Re: [PATCH 1/5] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

On Mon, 2013-12-16 at 12:59 +0100, Michal Suchanek wrote:

On 16 December 2013 11:05, Maxime Ripard
[off-list ref] wrote:

quoted

On Sun, Dec 15, 2013 at 11:01:17PM +0100, Michal Suchanek wrote:

quoted

On 15 December 2013 14:44, Maxime Ripard
[off-list ref] wrote:

quoted

quoted

--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig

@@ -665,3 +665,11 @@ config MMC_REALTEK_PCI
      help
        Say Y here to include driver code to support SD/MMC card interface
        of Realtek PCI-E card reader
+
+config MMC_SUNXI
+     tristate "Allwinner sunxi SD/MMC Host Controller support"
+     depends on ARCH_SUNXI
+     default y

I'm not that fond of these "default y" patterns. It forces the driver
down to every user of the multiplatform kernels. I'd suggest removing
the default and adding the driver to the defconfigs we have.

And why would you build support for sunxi without building support for
sunxi mmc?

Because you can?

But does that need to be the default? And is that sane default?

quoted

And where am I actually suggesting to do so?

Just a few lines above. You suggest it should not be built by default.

I'm pretty sure this isn't specific to sunxi, in the past Linus has
complained about the inappropriate use of "default y". Apparently it
should only be used rarely.

Note that default in the Kconfig is different to the defconfig file.

Ian.