Dear Rob

On Thu, Dec 5, 2013 at 10:29 PM, Rob Herring [off-list ref] wrote:

On Thu, Nov 7, 2013 at 11:38 PM, Zhangfei Gao [off-list ref] wrote:

quoted

+++ b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt

@@ -0,0 +1,83 @@
+* Hisilicon specific extensions to the Synopsys Designware Mobile
+  Storage Host Controller
+
+Read synopsis-dw-mshc.txt for more details
+The Synopsys designware mobile storage host controller is used to interface
+a SoC with storage medium such as eMMC or SD/MMC cards. This file documents
+differences between the core Synopsys dw mshc controller properties described
+by synopsis-dw-mshc.txt and the properties used by the Hisilicon specific
+extensions to the Synopsys Designware Mobile Storage Host Controller.
+
+Required Properties:
+
+* compatible: should be
+       - "hisilicon,hi4511-dw-mshc": for controllers with hi4511
+         specific extentions.
+* reg: should be address and size of mmc controller

This should be covered by the base binding.

Yes, got it.

quoted

+* vmmc-supply: should be vmmc used in dwmmc
+* fifo-depth: should be provided if register can not provide correct value
+* tuning-table: should be array to tune mmc controller, including clock rate
+       to be set and values for setting optional register.

Please define the size and what the values mean.

quoted

+
+Optional properties:
+
+/* These registers from pctrl node used for tuning mmc controller if required */
+* clken-reg: should be clock enable register and offset bit
+* drv-sel-reg: should be driver delay select register, start bit and bits numbers
+* sam-sel-reg: should be sample delay select register, start bit and bits numbers
+* div-reg: should be divider register, start bit and bits numbers

Do these really vary on different boards or versions of the IP? If
not, then put this information in the kernel.

Otherwise, these need better description such as number of words and
order of values.

Double checked these registers are not used in newer version.
Will follow Arnd's suggestion to abstract in clock.

quoted

+
+       /* Board portion */
+       dwmmc0 at fcd03000 {
+               num-slots = <1>;
+               vmmc-supply = <&ldo12>;
+               fifo-depth = <0x100>;
+               supports-highspeed;

Please reference that the binding uses standard SD properties (state
which binding document).

Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt is used for
base doc describing supports-highspeed.

quoted

+               pinctrl-names = "default";
+               pinctrl-0 = <&sd_pmx_pins &sd_cfg_func1 &sd_cfg_func2>;
+               slot at 0 {
+                       reg = <0>;
+                       bus-width = <4>;
+                       disable-wp;
+                       cd-gpios = <&gpio10 3 0>;
+               };
+       };
+
+PCTRL: Peripheral misc control register

Is this only MMC control bits? Seems like this belongs in its own doc.

OK, will move out.

Thanks