Thread (19 messages) 19 messages, 3 authors, 2013-12-17

[PATCH v3 1/9] mtd: nand: davinci: fix driver registration

From: ivan.khoronzhuk <hidden>
Date: 2013-12-17 10:23:18
Also in: linux-devicetree, lkml

On 12/17/2013 11:24 AM, Brian Norris wrote:
On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote:
quoted
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev)
  }
  
  static struct platform_driver nand_davinci_driver = {
+	.probe		= nand_davinci_probe,
  	.remove		= __exit_p(nand_davinci_remove),
I believe you need to drop the __exit_p() here. And now that you're
using module_platform_driver(), you need to drop the __init and __exit
from the probe() and remove() routines, to avoid section mismatch
warnings.
quoted
  	.driver		= {
  		.name	= "davinci_nand",
So on second thought, please resubmit the series with the requested
changes.

Thanks,
Brian
Thanks, Brian.
Do you want me to drop it in stand alone patch or in this one?

-- 
Regards,
Ivan Khoronzhuk
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help