On Thu, Dec 12, 2013 at 06:18:29AM -0500, Matt Porter wrote:
quoted hunk ↗ jump to hunk
/**
+ * struct phy_attrs - represents phy attributes
+ * @bus_width: Data path width implemented by PHY
+ */
+struct phy_attrs {
+ u32 bus_width;
Why u32?
quoted hunk ↗ jump to hunk
int phy_power_off(struct phy *phy);
+static inline u32 phy_get_bus_width(struct phy *phy)
+{
+ return phy->attrs.bus_width;
...
quoted hunk ↗ jump to hunk
+static inline u32 phy_get_bus_width(struct phy *phy)
+{
+ return -ENOSYS;
Why u32, especially as you're returning a negative number here.
If the bus width is a small integer (I'm assuming you don't have up to
2^30 bus signals) then what's wrong with it being an 'int' ?