[RFC v2 2/4] power: asv: Add a common ASV driver for Exynos SoCs.

Hi,

CC'ing Doug and Andrew who have also worked on ASV.

[...]

+
+       chip_id = of_find_compatible_node(NULL, NULL,
+                                               "samsung,exynos4210-chipid");
+       if (!chip_id) {
+               pr_err("%s: unable to find chipid\n", __func__);
+               return -ENODEV;
+       }
+
+       base = of_iomap(chip_id, 0);
+       if (!base) {
+               dev_err(&pdev->dev, "unable to map chip_id register\n");
+               ret = -ENOMEM;
+               goto err_map;
+       }

My u-boot had the chipid clock disabled and I was getting an invalid
value at 1000_0004 (0 on the SMDK5420 and 0x43520010 on the
chromebook). Maybe it would be better if we enable the chipid clock in
the driver as well.

+
+       exynos_asv_info->base = base;
+
+       /* call SoC specific intialisation routine */
+
+       register_asv_member(exynos_asv_info->asv_list, exynos_asv_info->nr_mem);
+
+       iounmap(base);
+err_map:
+       of_node_put(chip_id);
+
+       return ret;
+}

[...]

Please fix the copyright

Thanks,
Abhilash