[PATCH v3 36/36] ARM: STi: Add support for the FSM Serial Flash Controller

On Mon, 02 Dec 2013, srinivas kandagatla wrote:

On 02/12/13 13:20, Lee Jones wrote:

quoted

quoted

quoted

+		/* FSM */
+		spifsm: spifsm at fe902000{
+		        compatible         = "st,spi-fsm", "simple-bus";

"simple-bus" is redundant here.

Yes I agree, good spot.

I removed it from the Documentation, but missed this one.

If I remove it, can I add your Ack for the remainder of the patch?

Yes,

Acked-by: Srinivas Kandagatla <redacted>

You should be aware that arch/arm/boot/dts/stih416-b2105.dts is not in
mainline yet.

Yes, I am aware of this. Are you queuing patches for it?

quoted

quoted

quoted

+		        reg                =  <0xfe902000 0x1000>;
+		        reg-names          = "spi-fsm";
+		        pinctrl-0          = <&pinctrl_fsm>;
+
+			st,syscfg	   = <&syscfg_rear>;
+		        st,boot-device-reg = <0x958>;
+		        st,boot-device-spi = <0x1a>;
+
+		        status = "okay";
+		};

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog