[PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init
From: Philippe Rétornaz <hidden>
Date: 2013-12-02 08:30:35
Also in:
lkml
From: Philippe Rétornaz <hidden>
Date: 2013-12-02 08:30:35
Also in:
lkml
Le 30/11/2013 10:53, Alexander Shiyan a ?crit :
If this driver being loaded from devicetree, the pdata is NULL. This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or "fsl,mc13xxx-uses-touch" properties is specified.
Well, the codec and touch are not supported if DT is used, thus why bothering ? Just don't specify thoses properties. IMHO it would be better to either implement full DT support in the subdevices or removing the check for the fsl,mc13xxx-uses-codec and fsl,mc13xxx-uses-touch in mc13xxx_probe_flags_dt(). If it's not supported let's not lie about it. Regards, Philippe