[Cocci] Warning masked by BUG() when CONFIG_BUG is enabled
From: Wolfram Sang <hidden>
Date: 2013-11-17 14:06:39
Also in:
cocci, linux-gpio
From: Wolfram Sang <hidden>
Date: 2013-11-17 14:06:39
Also in:
cocci, linux-gpio
As a side note, I noticed quite some instances of that pattern (switch statement w/ a 'default' calling BUG()) while more carefully looking at compilation output. I may get slapped for this, but just in case this is indeed something which deserves to be fixed and can be fixed automagically via some semantic patch, I have CC'ed Coccinelle people.
I don't think this can be fixed in a generic way. This driver, for example, should IMO return -EINVAL when hitting default in probe and simply get rid of the other BUG() calls. No need to halt the kernel because of a broken match->data. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131117/ec18a9f3/attachment.sig>