[PATCH V4] kbuild: dtbs_install: new make target
From: Stephen Warren <hidden>
Date: 2013-11-19 21:58:05
Also in:
linux-devicetree
On 11/19/2013 02:27 PM, Jason Cooper wrote:
Unlike other build products in the Linux kernel, there is no 'make
*install' mechanism to put devicetree blobs in a standard place.
This patch is an attempt to fix this problem. Akin to 'make install',
this creates a new make target, dtbs_install. The script that gets
called defers to a distribution or user supplied installdtbs binary,
if found in the system. Otherwise, the default action is to install a
given dtb into
/lib/modules/${kernel_version}/devicetree/${dts_filename}.dtbI still don't see why you wouldn't install the files in /lib/devicetrees, but I suppose that location is fine.
This is done to keep dtbs from different kernel versions separate until things have settled down. Once the dtbs are stable, and not so strongly linked to the kernel version, the devicetree files will most likely move to their own repo. Users will need to upgrade install scripts at that time. Signed-off-by: Jason Cooper <redacted> --- Question: should I make a note about the filenames not being considered an ABI, or just let it be?
I still believe they're an ABI. I guess Grant meant that they aren't an ABI to the kernel at run-time, unlike the content which is an ABI. That's fine. However, I believe the files certainly are an ABI to any script that takes them from the "make dtbs_install" output directory. Perhaps the best resolution is to just say nothing and let it be:-)
quoted hunk
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
+dtbs_install: dtbs + $(CONFIG_SHELL) $(srctree)/scripts/installdtbs.sh $(KERNELRELEASE) \ + "$(MODLIB)/devicetree" "$(srctree)/$(boot)/dts"
I still think this rule should be in Makefile not arch/arm/Makefile. Aside from those couple of issues, this version looks OK to me.