Thread (20 messages) 20 messages, 4 authors, 2013-10-29
STALE4596d

[PATCH RFC v2 3/4] net: mvmdio: slight optimisation of orion_mdio_write

From: davem@davemloft.net (David Miller)
Date: 2013-10-26 05:45:45
Also in: netdev

From: Leigh Brown <redacted>
Date: Thu, 24 Oct 2013 19:09:33 +0100
Make only a single call to mutex_unlock in orion_mdio_write.

Signed-off-by: Leigh Brown <redacted>
You patch does more than what you're talking about here in your
commit message.  In particular you're also changing the interpretation
of the orion_mdio_wait_ready() return value by changing the test
from < 0 to != 0.

Even if that is a legitimate change:

1) You're not describing it in the commit message@all.

2) It's a logically separate change, so should go into a completely
   separate patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help