* Tony Lindgren [off-list ref] [131018 09:38]:

* Felipe Balbi [off-list ref] [131018 09:19]:

quoted

quoted

@@ -786,7 +813,10 @@ static void serial_omap_shutdown(struct uart_port *port)
 
 	pm_runtime_mark_last_busy(up->dev);
 	pm_runtime_put_autosuspend(up->dev);
-	free_irq(up->port.irq, up);
+
+	for (i = 0; i < ARRAY_SIZE(up->irqs); i++)
+		if (up->irqs[i])
+			devm_free_irq(up->port.dev, up->irqs[i], up);

do you need this at all if you're using devm_* ?

So it seems, startup and shutdown are managed by serial_core and
that's what at least clps711x.c serial driver is doing.

And that means devm_* in this case does not really help us
here..

I guess we could keep the IRQ requested from probe, but
there's probably a reason why it's done in startup/shutdown.

So I'll just drop the devm_* changes for now.

Regards,

Tony