On Monday 14 October 2013 01:32 PM, Kevin Hilman wrote:

Santosh Shilimkar [off-list ref] writes:

quoted

On Thursday 29 August 2013 07:36 PM, Santosh Shilimkar wrote:

quoted

Add runtime PM core support to Keystone SOCs by using the pm_clk
infrastructure of the PM core. Patch is based on Kevin's pm_domain
work on DaVinci SOCs.

Keystone SOC doesn't have depedency to enable clocks in early
in the boot and hence the clock and PM bus initialisation is done
at subsys_init() level.

Cc: Kevin Hilman <redacted>

Signed-off-by: Santosh Shilimkar <redacted>
---

For record, updated patch end of the email as discussed here [1]

Unfortunately, this one broke boot for muilti_v7_defconfig:

   http://lists.linaro.org/pipermail/kernel-build-reports/2013-October/000652.html

Damn. Sorry about that.

 

[...]

quoted

+int __init keystone_pm_runtime_init(void)
+{
+	of_clk_init(NULL);
+	pm_clk_add_notifier(&platform_bus_type, &platform_domain_notifier);
+
+	return 0;
+}
+subsys_initcall(keystone_pm_runtime_init);

The reason is this initcall which runs on *all* platforms, so needs some
sort of platform specific check.  

The patch below does the trick, but I'm not sure if you want to match on
something more specific for this check.  If you're OK, with this, I'll
add it to next/soc with your ack.

Kevin

From 435ed298c804048548276b60fd5efdf697f6b82f Mon Sep 17 00:00:00 2001
From: Kevin Hilman <redacted>
Date: Mon, 14 Oct 2013 10:30:11 -0700
Subject: [PATCH] ARM: keystone: fix PM domain initcall to be keystone only

initcalls need to have platform specific checks so they are not run in
multi-platform builds.

Cc: Santosh Shilimkar <redacted>
Signed-off-by: Kevin Hilman <redacted>
---

Acked-by: Santosh Shilimkar <redacted>
Looks right. Thanks a lot Kevin.