[PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

On Fri, 4 Oct 2013, Will Deacon wrote:

Hi Ard,

On Thu, Oct 03, 2013 at 10:59:23PM +0100, Ard Biesheuvel wrote:

quoted

Note to reviewers:
Reviewing the file aesbs-core.S may be a bit overwhelming, so if there are any
questions or concerns, please refer the file bsaes-armv7.pl which can be found
at the link below. This is the original Perl script that gets called by
OpenSSL's build system during their build to generate the .S file on the fly.
[In the case of OpenSSL, this is used in some cases to target different
assemblers or ABIs]. This arrangement is not suitable (or required) for the
kernel, so I have taken the generated .S file instead.

    http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=6f6a6130

This series still depends on commit a62b01cd (crypto: create generic version of
ablk_helper) which I omitted this time but which can be found in the cryptodev
tree or in linux-next.

Why do you consider it unsuitable to ship the perl script with the kernel?
Perl 5 is already documented as a build dependency in Documentation/Changes

Do you have an example of something that does require perl to build the 
kernel on ARM?  I was under the impression that people try to avoid it 
as much as possible in general.

I'm personally sitting on the fence between effectively adding a new 
kernel build dependencies or carrying the output of the perl script.  
But if the kernel build does already require perl in practice then this 
might tip the balance.


Nicolas