Thread (1 message) 1 message, 1 author, 2013-10-27

[PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

From: Chris Ball <hidden>
Date: 2013-10-27 02:28:19
Also in: linux-devicetree, linux-mmc

Hi Zhangfei, just small changes,

On Wed, Oct 23 2013, Zhangfei Gao wrote:
+* tune-table: should be array of clock tune mmc controller
This sounds like it should be "tuning-table", and shouldn't it also
have a prefix?
+			node = of_find_compatible_node(NULL, NULL,
+						"hisilicon,pctrl");
No need to use two lines here.
+		ret = of_property_read_u32_array(np,
+				"clken-reg", data, 2);
Or here, same with the other of_property_read_u32_array() calls.
+MODULE_DESCRIPTION("K3 Specific DW-MSHC Driver Extension");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:dwmmc-k3");
Can you add a MODULE_AUTHOR too?

Thanks,

- Chris.
-- 
Chris Ball   [off-list ref]   <http://printf.net/>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help