[PATCH v2 3/5] pinctrl: rockchip: remove redundant check
From: heiko@sntech.de (Heiko Stübner)
Date: 2013-10-15 23:08:11
Also in:
linux-devicetree
Subsystem:
arm/rockchip soc support, pin control subsystem, the rest · Maintainers:
Heiko Stuebner, Linus Walleij, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2013-10-16 · Re: [PATCH v2 3/5] pinctrl: rockchip: remove redundant check · Linus Walleij <hidden>
The check limiting bias options to supported ones is already done thru rockchip_pinconf_pull_valid. Therefore this check is redundant and can be removed. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- drivers/pinctrl/pinctrl-rockchip.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index efca116..91027dd 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c@@ -424,12 +424,6 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank, switch (ctrl->type) { case RK2928: - if (pull != PIN_CONFIG_BIAS_PULL_PIN_DEFAULT && - pull != PIN_CONFIG_BIAS_DISABLE) { - dev_err(info->dev, "only PIN_DEFAULT and DISABLE allowed\n"); - return -EINVAL; - } - ctrl->pull_calc_reg(bank, pin_num, ®, &bit); spin_lock_irqsave(&bank->slock, flags);
--
1.7.10.4