[PATCH 4/8] input: Remove OOM message after input_allocate_device
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
Date: 2013-10-24 18:37:15
Also in:
linux-input, linux-samsung-soc, lkml
Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done.
No, please don't. The kzalloc may get changed in the future to not dump stack (that was added originally because not everyone was handling OOM properly, right?), input core might get changed to use something else than kzalloc, etc, etc. The majority of errors use dev_err so we also get idea what device failed (if there are several), and more. Thanks. -- Dmitry