Thread (43 messages) 43 messages, 5 authors, 2013-10-25

[PATCH v8 08/19] arm/xen: get_dma_ops: return xen_dma_ops if we are running as xen_initial_domain

From: Russell King - ARM Linux <hidden>
Date: 2013-10-18 15:43:08
Also in: lkml, xen-devel

On Fri, Oct 18, 2013 at 01:22:18PM +0100, Stefano Stabellini wrote:
Russell,
are you OK with this patch?
Only concern is why the change is soo large.
quoted
-static inline struct dma_map_ops *get_dma_ops(struct device *dev)
+static inline struct dma_map_ops *__generic_dma_ops(struct device *dev)
 {
 	if (dev && dev->archdata.dma_ops)
 		return dev->archdata.dma_ops;
 	return &arm_dma_ops;
 }
 
+static inline struct dma_map_ops *get_dma_ops(struct device *dev)
+{
+	if (xen_initial_domain())
+		return xen_dma_ops;
+	else
+		return __generic_dma_ops(dev);
+}
+
What's wrong with:

 static inline struct dma_map_ops *get_dma_ops(struct device *dev)
 {
+	if (xen_initial_domain())
+		return xen_dma_ops;
 	if (dev && dev->archdata.dma_ops)
 		return dev->archdata.dma_ops;
 	return &arm_dma_ops;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help