Thread (39 messages) flat view 39 messages, 2 authors, 2013-10-17

[PATCH v3 10/19] clk: tegra: move audio clk to common file

From: Stephen Warren <hidden>
Date: 2013-10-15 19:13:50
Also in: linux-devicetree, linux-tegra, lkml

On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
Move audio clocks and PLLA initialization to a common file so it can be used by
multiple Tegra SoCs.
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
+static struct tegra_clk tegra114_clks[tegra_clk_max] __initdata = {
+	[tegra_clk_rtc] = { .dt_id = TEGRA114_CLK_RTC, .present = true },
+	[tegra_clk_timer] = { .dt_id = TEGRA114_CLK_TIMER, .present = true },
+	[tegra_clk_uarta] = { .dt_id = TEGRA114_CLK_UARTA, .present = true },
...
quoted hunk ↗ jump to hunk
@@ -2194,7 +2167,7 @@ static void __init tegra114_clock_init(struct device_node *np)
...
+	tegra_audio_clk_init(clk_base, pmc_base, tegra114_clks, &pll_a_params);
I think it's worth explaining in the commit description why an array of
not-remotely-audio-related clocks is being passed into an
audio-clock-initialization function.

I see now that it's because not all SoCs have the same set of clocks,
and this table is what tells the common audio code which clocks to
actually create for this SoC, but that wasn't obvious, and hence should
be explicitly described.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help