Thread (33 messages) 33 messages, 4 authors, 2013-10-11

[PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

From: tony@atomide.com (Tony Lindgren)
Date: 2013-10-11 16:11:25
Also in: linux-devicetree, linux-omap, lkml

* Joel Fernandes [off-list ref] [131010 08:31]:
On 10/10/2013 10:20 AM, Joel Fernandes wrote:
quoted
Adding 6 lines of identical code for every platform seems redundant, I'd just
define an omap_common_late_init for all platforms for now, and then fork off for
the future differences. That way we save on LOC and readability in the header as
well. Your call.
I see a function of that name already exists. I guess you can leave your patch
as is then and not have to do this.
Yeah but why not just call the common late_init function directly for the
cases where we know it's never needed.

If thoses will be populated in the later patches, then it's OK to add them.

In any case, Nishant, can you please squash the late_init patches into a
single patch and make sure it also applies on top of the omap-for-v3.13/quirk
branch as there's been some changes to board-generic.c there.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help