[PATCH] ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup
From: horms@verge.net.au (Simon Horman)
Date: 2013-09-26 21:44:07
Also in:
linux-sh, netdev
On Wed, Sep 25, 2013 at 11:50:45PM -0700, Magnus Damm wrote:
On Fri, Sep 13, 2013 at 5:29 PM, Sergei Shtylyov [off-list ref] wrote:quoted
Currently on the Lager board NFS timeouts/delays are seen when booting. That turned out to happen because the SoC's ETH_LINK signal turns on and off after each packet. It is connected to Micrel KSZ8041 PHY's LED0 signal. Ether LEDs on the Lager board are named LINK and ACTIVE which corresponds to non-default 01 setting of the PHY control register 1 bits 14-15. The 'sh_eth' driver resets the PHY when opening the network device, so we have to set the mentioned bits back to 01 from the default 00 value which causes bouncing of ETH_LINK. That can be achieved using the PHY platform fixup mechanism if we also modify the driver to use it.. Signed-off-by: Sergei Shtylyov <redacted>Hi Sergei, Thanks for your efforts on this. Nice to see that Ethernet for Lager board support is improving. Can you please share with us with link speeds you tested? I suspect that this patch is only needed for some case, like for instance 100 MBit Full Duplex. Fixing the PHY settings makes sense even though only a single mode needs it, but knowing which link speeds that are known to work would help a lot.
Magnus, I currently have this queued up as a fix for v3.12. Let me know if you would like me to drop it for now.