[PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

Hi Marek,

On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote:

quoted

On Monday 09 September 2013 18:04:19 Marek Vasut wrote:

quoted

quoted

Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC
at least for the 4 wire touchscreen.

Signed-off-by: Juergen Beisert <redacted>
CC: linux-arm-kernel at lists.infradead.org
CC: devel at driverdev.osuosl.org
CC: Marek Vasut <marex@denx.de>
CC: Fabio Estevam <redacted>
CC: Jonathan Cameron <redacted>

This patch seems to combine two things -- register access rework AND
adjustment of the driver for MX23 touchscreen.

It reworks the register access to avoid the i.MX23/i.MX28 runtime
decision all over the code again and again. This is what Dan has
recommended in his comment.

Sure, but this change should be separated from fixing the touchscreen
support then.

Hmm, but there is no need to rework the register access until the i.MX23 
touchscreen support is added. So this patch does both at the same time.

quoted

quoted

Btw the MX23 ADC was already supported,

No. This patch is the first in this series which brings in the specific
register bits, because the ADC units in the i.MX23 and i.MX28 differ.

quoted

so this "add i.MX23 support" commit message is not accurate.

Hmmm, what else do you think should I write?

You're just correcting the touchscreen support, no ?

Okay, will change the subject.

Regards,
Juergen

-- 
Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Beisert ? ? ? ? ? ? |
Linux Solutions for Science and Industry ? ? ?| http://www.pengutronix.de/  |