Thread (2 messages) 2 messages, 2 authors, 2013-09-20

[PATCH 5/7] staging: media/lirc: switch to use gpiolib

From: khc@pm.waw.pl (Krzysztof Halasa)
Date: 2013-09-13 12:15:32
Also in: linux-gpio

Linus Walleij [off-list ref] writes:
quoted hunk
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -839,6 +839,16 @@ static int lirc_serial_probe(struct platform_device *dev)
 {
 	int i, nlow, nhigh, result;
 
+#ifdef CONFIG_LIRC_SERIAL_NSLU2
+	/* This GPIO is used for a LED on the NSLU2 */
+	result = devm_gpio_request(dev, NSLU2_LED_GRN, "lirc-serial");
Will this succeed with the LED driver already loaded? Should the user
unload it first?

Otherwise, while I don't have any of the hw in question, I can't see
other obvious problems, so for the whole patchset:

Acked-by: Krzysztof Halasa <khc@pm.waw.pl>
-- 
Krzysztof Halasa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help