Thread (4 messages) 4 messages, 3 authors, 2013-09-26

[PATCH 2/7] misc: ixp4-beeper: switch to use gpiolib

From: Linus Walleij <hidden>
Date: 2013-09-13 08:21:43
Also in: linux-gpio

On Tue, Sep 10, 2013 at 11:48 PM, Arnd Bergmann [off-list ref] wrote:
On Tuesday 10 September 2013, Linus Walleij wrote:
quoted
Arnd/Greg: seeking your ACK to take this through the GPIO tree
as part of the attempt at cleaning out custom GPIO implementations.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks!
quoted
+     if (count) {
+             gpio_direction_output(pin, 0);
              *IXP4XX_OSRT2 = (count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE;
      } else {
Too bad we can't just clean up all the open-coded mmio accesses as well. It shouldn't
be hard, but some platforms are full of them, and there is definitely some regression
potential.
Yeah :-/

I'm poking the IXP4 people a bit, it seems to have a large hobbyist
following due to all the NSLU2 hackers out there so lets see if someone
picks up the challenge to go and clean up this stuff.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help