[PATCH] media: i2c: adv7343: fix the DT binding properties
From: broonie@kernel.org (Mark Brown)
Date: 2013-09-24 15:54:43
Also in:
linux-devicetree
Possibly related (same subject, not in this thread)
- 2013-09-30 · Re: [PATCH] media: i2c: adv7343: fix the DT binding properties · Laurent Pinchart <laurent.pinchart@ideasonboard.com>
- 2013-09-30 · Re: [PATCH] media: i2c: adv7343: fix the DT binding properties · Prabhakar Lad <prabhakar.csengg@gmail.com>
- 2013-09-24 · Re: [PATCH] media: i2c: adv7343: fix the DT binding properties · Prabhakar Lad <hidden>
- 2013-09-23 · Re: [PATCH] media: i2c: adv7343: fix the DT binding properties · Prabhakar Lad <prabhakar.csengg@gmail.com>
- 2013-09-20 · Re: [PATCH] media: i2c: adv7343: fix the DT binding properties · Sylwester Nawrocki <hidden>
On Mon, Sep 23, 2013 at 01:50:51PM +0200, Laurent Pinchart wrote:
Isn't regulator_get_optional() intended for devices that can have supplies unconnected in normal use ? The ADV7343 supplies are mandatory from a hardware point of view, so I think we should use regulator_get(). Otherwise the driver won't be able to tell the difference between a regulator that isn't present yet (for instance because the regulator device/driver hasn't been probed yet), which should result in deferred probing, and an always-on regulator that has been left out.
Yes, everything you say here is correct. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130924/fc1dba98/attachment-0001.sig>