Thread (1 message) 1 message, 1 author, 2013-09-21

[PATCH v2 1/2] ASoC: kirkwood: clk: probe defer when clock not yet ready

From: Russell King - ARM Linux <hidden>
Date: 2013-09-21 10:51:52
Also in: alsa-devel, linux-devicetree

On Sat, Sep 21, 2013 at 11:47:34AM +0100, Russell King - ARM Linux wrote:
Another comment.  This is broken - it will never fall through if a
'dev' is given, because of_clk_get_by_name() will always return an
-EPROBE_DEFER error pointer in that case.

So this approach is unworkable.
And another comment:

This whole approach is broken - while Mark is correct that we should
find a way to return -EPROBE_DEFER if a clock is specified, the solution
here does not allow that - it will return -EPROBE_DEFER whenever the
clock is not found _or_ is not specified.

This has the effect of making the external clock *non*optional for the
kirkwood-i2s driver, which is also completely broken.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help