Thread (7 messages) flat view 7 messages, 3 authors, 2013-10-17

[PATCH] TTY: hvc_dcc: probe for a JTAG connection before registering

From: Tim Gardner <hidden>
Date: 2013-09-23 21:10:30
Also in: lkml

On 09/23/2013 01:30 PM, Rob Herring wrote:
quoted hunk ↗ jump to hunk
From: Rob Herring <redacted>

Enabling the ARM DCC console and using without a JTAG connection will
simply hang the system. Since distros like to turn on all options, this
is a reoccurring problem to debug. We can do better by checking if
anything is attached and handling characters. There is no way to probe
this, so send a newline and check that it is handled.

Cc: Paolo Pisati <redacted>
Cc: Tim Gardner <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <redacted>
Signed-off-by: Rob Herring <redacted>
---
 drivers/tty/hvc/hvc_dcc.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
diff --git a/drivers/tty/hvc/hvc_dcc.c b/drivers/tty/hvc/hvc_dcc.c
index 44fbeba..44c8aff 100644
--- a/drivers/tty/hvc/hvc_dcc.c
+++ b/drivers/tty/hvc/hvc_dcc.c
@@ -86,6 +86,21 @@ static int hvc_dcc_get_chars(uint32_t vt, char *buf, int count)
 	return i;
 }
 
+static bool hvc_dcc_check(void)
+{
+	unsigned long time = jiffies;
+
+	/* Write a test character to check if it is handled */
+	__dcc_putchar('\n');
+
+	while (jiffies < time + (HZ / 10)) {
+		if (!(__dcc_getstatus() & DCC_STATUS_TX))
+			return true;
+	}
I think you should use one of the jiffies time comparison functions, e.g.,

	time = jiffies + (HZ / 10);
	while (time_before(jiffies,time) {
		...
	}

What is the possibility that __dcc_getstatus() will return garbage if no
JTAG is connected ? In that event you're likely to get a false positive
on DCC_STATUS_TX.

rtg


-- 
Tim Gardner tim.gardner at canonical.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help