Thread (42 messages) 42 messages, 6 authors, 2014-02-07

[RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

From: Sergei Shtylyov <hidden>
Date: 2013-09-23 14:10:46
Also in: linux-devicetree, linux-ide, linux-omap, lkml

Hello.

On 09/23/2013 01:48 AM, Tejun Heo wrote:
quoted
quoted
@@ -37,6 +37,7 @@
quoted
quoted
  #include <linux/clk.h>
  #include <linux/libata.h>
+#include <linux/phy/phy.h>
quoted
struct phy;
quoted
should suffice.
Unless it's actually likely to cause inclusion loop, I think it's
better to include the header than adding explicit declarations.
    Apparently, tastes differ here. E.g. Greg KH would have also told Roger to 
use forward declaration in such case. :-)
Thanks.
WBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help